Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change the concurrency queue locking mechanism, example readme #1

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

oscb
Copy link
Contributor

@oscb oscb commented May 9, 2023

  • The way that timeline queued the processing was prone to concurrency issues depending on where the execution halted which could lead to deadlocks or accessing wrong indexes.
  • Reverting to a simpler locking queue mechanism that guarantees that the operations will always be executed in line and the futures completed without swapping values
  • Added instructions on how to run the example app for the first time.

Copy link

@bsneed bsneed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how much simpler it seems to be.

@marketoptiontend marketoptiontend linked an issue Jun 26, 2023 that may be closed by this pull request
@MichaelGHSeg MichaelGHSeg merged commit 505ac1e into main Jun 28, 2023
@MichaelGHSeg MichaelGHSeg deleted the oscb/concurrencyFix branch June 28, 2023 15:05
@GeorgePagMezzi GeorgePagMezzi mentioned this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Company
3 participants